Use minimum necessary division precision in BigDecimal_DoDivmod#371
Merged
tompng merged 1 commit intoruby:masterfrom Jul 17, 2025
Merged
Use minimum necessary division precision in BigDecimal_DoDivmod#371tompng merged 1 commit intoruby:masterfrom
tompng merged 1 commit intoruby:masterfrom
Conversation
tompng
force-pushed
the
divmod_internal_div_prec
branch
from
09f314a to
d72e530
Compare
Merged
tompng
force-pushed
the
divmod_internal_div_prec
branch
from
d72e530 to
3b70d93
Compare
Integer division part of a.divmod(b) only needs (a.exponent-b.exponent+1) digits precision.
tompng
force-pushed
the
divmod_internal_div_prec
branch
from
3b70d93 to
0f9e35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of
divanddivmodin some case.In the above example,
divneeds to calculate division with 2-digits precision. But it was internally calculating with 200000-digits precision.This pull request also fixes the cause of this bug (found while adding test)
but this bug was fixed by a side effect of #377